fix(big-play-button): component remains displayed after an error #8483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8483 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 113 113
Lines 7592 7592
Branches 1826 1826
=======================================
Hits 6280 6280
Misses 1312 1312 ☔ View full report in Codecov by Sentry. |
mister-ben
approved these changes
Nov 4, 2023
This issue occurs when the `player` has the class `vjs-show-big-play-button-on-pause` and playback has started and then been set to `pause` and an `error` occurs. - Avoids displaying `big-play-button` on error
amtins
force-pushed
the
fix/big-play-button-on-error
branch
from
2ef0517 to
7a6263a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue occurs when the
playerhas the classvjs-show-big-play-button-on-pauseand playback has started and then been set topauseand anerroroccurs.Screencast.from.04.11.23.18.16.08.webm
Specific Changes proposed
big-play-buttonon errorRequirements Checklist